Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faulty index subscription #4891

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Jun 6, 2016

The table catalog_product_entity_media_gallery does not have a column
that represents a product entity_id so it cannot be subscribed to
triggers for catalogrule_product or catalog_product_flat

The current value_id is not a product entity_id so 88891ed
should have never been approved. Insead the whole subscription should
be removed. For now there is no way to trigger an indexer when the
name if an image changes. If the image gets deleted or added the
subscription on catalog_product_entity_media_gallery_value will
handle it.

@vkublytskyi vkublytskyi added the MX label Jun 6, 2016
@vkorotun vkorotun removed the MX label Aug 3, 2016
@vkorotun vkorotun added bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bugfix and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 4, 2016
@ishakhsuvarov
Copy link
Contributor

@ajpevers Hi, could you please update your branch with the current develop?

The table catalog_product_entity_media_gallery does not have a column
that represents a product entity_id so it cannot be subscribed to
triggers for catalogrule_product or catalog_product_flat

The current value_id is not a product entity_id so magento@88891ed
should have never been approved. Insead the whole subscription should
be removed. For now there is no way to trigger an indexer when the
name if an image changes. If the image gets deleted or added the
subscription on catalog_product_entity_media_gallery_value will
handle it.
@AntonEvers
Copy link
Contributor Author

@ishakhsuvarov done

@okorshenko okorshenko modified the milestones: April 2017, May 2017 May 9, 2017
@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@magento-team magento-team merged commit 9fe3b8a into magento:develop Jun 13, 2017
@AntonEvers AntonEvers deleted the media_gallery_fix branch June 14, 2017 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants