-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code to pass hostname to Varnish and optimally only purge the current domain. #4905
Conversation
Add code to forward the hostname to varnish when purging the cache.
Add code to read hostname and sample code to only purge current domain.
Added code to track hostname and sample code to purge only the current domain.
HI @pynej Unfortunately we can not accept this PR. In current implementation it is incompatible with latest changes in develop branch. Please reopen this PR once ready for delivery. Thank you |
Yah, I'm not going to be doing that as I reported the issues and patch over year ago. |
Another community powered improvement gone to waste. |
Hi @woutersamaey as I said we can not accept broken code to mainline. This is good improvement, but it must work. Please, let us know If you would like to proceed with this PR. We will do our best to help you. Thank you. |
I understand you have a process in place @okorshenko, but it's just not working. Essential stuff, you should care about. But instead you want us to do all the work. It's just not a group effort. Now assume that @pynej fixes this issue, you may or may not accept the PR. And when it is finally accepted, it may still be another year before we see it in a release and can actually benefit from his work. At least this is the impression that I got from many essential improvements and bug fixes lying around. The current process is not working as it should be. You should put developers on these issues to help out, work we contribute should end up in a release no more than 3 months after it was made and you should publish statistics so that people can actually see the community and process work and regain confidence. When we start out a project, we run into issues. Old issues, that have been fixed most of the time already. Instead, we keep fighting old fights, which is downright depressing. There's also a reason i say 3 months, because most projects take this long. When we contribute, we should get our own improvements in a timely fashion. Now, we're disconnecting, losing interest like @pynej Don't forget it's the developers that make the community. Ps: Sorry for going on like this. I'm very passionate about Magento and would love to see improvements in this key area. |
[TSG-Commerce] Tests for 2.3 (pr1) (2.3-develop)
#4871