Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'select' to 'query' in props #5043

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Change 'select' to 'query' in props #5043

merged 3 commits into from
Apr 13, 2017

Conversation

flancer64
Copy link
Contributor

@flancer64 flancer64 commented Jun 15, 2016 •
edited by okorshenko
Loading

See #5040

flancer64 added 2 commits June 15, 2016 17:22
@flancer64
Change 'select' to 'query' in props
7c534a2 
See #5040
@flancer64
Fix Travis CI error
a4d6994 
63 | ERROR | Expected 5 space(s) before asterisk; 4 found
@vkublytskyi vkublytskyi added the PS label Jun 17, 2016
vkublytskyi
vkublytskyi reviewed Jun 17, 2016
View reviewed changes
lib/internal/Magento/Framework/Data/AbstractSearchResult.php
@@ -59,9 +59,9 @@
protected $entityFactory;

/**
* @var \Magento\Framework\DB\Select
* @var \Magento\Framework\DB\Query
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface \Magento\Framework\DB\QueryInterface should be used instead of concrete class

@flancer64
QueryInterface & old $select
fca2421 
- use interface instead of class itself;
- leave deprecated $select property;
@daim2k5
Copy link
Contributor

daim2k5 commented Jun 23, 2016

@flancer64 Thank you for your contribution. Please accept the contributors license agreement so this PR can be further processed. This can be done by clicking the "Details" link next to the "license/cla" check below.

@flancer64
Copy link
Contributor Author

@daim2k5 , I did it twice but licence/cla is in "is not signed yet" state still.

@daim2k5
Copy link
Contributor

daim2k5 commented Jun 25, 2016

@flancer64 i try to forward this issue

@ghost
Copy link

ghost commented Aug 9, 2016

Opened internal task item MAGETWO-56719

@ghost ghost added the linked label Aug 9, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@okorshenko okorshenko self-assigned this Apr 12, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 12, 2017
@magento-team magento-team merged commit fca2421 into magento:develop Apr 13, 2017
magento-team pushed a commit that referenced this pull request Apr 13, 2017
MAGETWO-67408: Change 'select' to 'query' in props #5043
4a22761
@magento-team
Copy link
Contributor

@flancer64 thank you for your contribution to Magento 2 project

@flancer64 flancer64 deleted the patch-1 branch April 13, 2017 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@flancer64 @daim2k5 @magento-team @vkublytskyi @okorshenko @vkorotun