Fix runner for JsTestDriver based tests on OS X #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vinai Thanks for contributing! Our internal ticket - MAGETWO-57857 |
MomotenkoNatalia
added
the
Issue: Ready for Work
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 21, 2019
[arcticfoxes] MC-22813: Changing Quantity and Adding to cart throws exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes:
Background
Only applications compiled for X11 can use Xvfb to run in headless mode, since actually it's not the browsers running in headless mode but the X11 server.
Firefox (or Chrome or Safari) on OS X do not use X11 but Aqua. This means they can not run in headless mode.
It is possible to install Xvfb on OS X using the XQuartz project, but even then the browsers will not use the headless X11 server.
It is possible to compile Firefox on OS X to use X11, but that is quite involved and should not be required to run the JS tests.
Under OS X the JsTestRunner should simply start an instance of Firefox in the background and run the tests.