Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underscore as dependency to quote.js #5066

Merged

Conversation

Bartlomiejsz
Copy link
Contributor

Underscore is used in Magento_Checkout/view/frontend/web/js/model/quote.js file, but it's not added as dependency.

@antboiko
Copy link

Hi @Bartlomiejsz thank you for your contribution, we have ticket MAGETWO-56011 to process this PR.

Best,
Anton.

@sshrewz sshrewz added the linked label Aug 11, 2016
@mmansoor-magento mmansoor-magento merged commit 39ec4d4 into magento:develop Aug 12, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@Bartlomiejsz Bartlomiejsz deleted the Underscore_In_Quote_Model branch August 30, 2016 06:56
@Ctucker9233
Copy link

Was this merge included in the 2.1.1 release?

@Bartlomiejsz
Copy link
Contributor Author

No, unfortunately it wasn't...

magento-engcom-team pushed a commit that referenced this pull request Dec 2, 2019
[honey] MC-23091: Optimize product queries to obtain better wall time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants