Fix integration test expectation to match count of countries in the database

[Vinai]

This PR applies to the 2.1.0-rc3 and develop branches.
It probably already is fixed upstream though since it is a simple test failure due to a hardcoded expectation that actually is a value from the database.

Details:
The number of countries in the database seems to have changed.
The test \Magento\Sales\Block\Adminhtml\Order\Create\Form\AddressTest::testGetForm() hardcoded the expected number of options in the country select to 246.
The number of records created in that table by \Magento\Directory\Setup\InstallData::install() is 245.
This PR adjusts the test so it expects the number of options in the select to match the number countries in the system country directory.

[Vinai]

Strange - locally the original test fails because it expects 246 (hardcoded), but the country select only contains 245 options, so my change made it pass.
But in the travis build there is an extra option in the select option list that isn't there locally.
Where is the option list built?
What causes the difference?

[Vinai]

I can't look into travis to see what happens there, but at least I can look how the local option count ends up being 245:

The country options list is created by \Magento\Directory\Model\ResourceModel\Country\Collection::toOptionArray().
The collection contains 245 items. One for each record in the database.
The following loop filters out countries with an empty country name for the locale.

foreach ($options as $data) {
    $name = (string)$this->_localeLists->getCountryTranslation($data['value']);
    if (!empty($name)) {
        $sort[$name] = $data['value'];
    }
}

In the local build, $name is empty for Andorra ($data['name] == 'AN');
After that loop the count of countries is down to 244.

Then, at the end of the toOptionArray() method, an empty option is prepended:

if (count($options) > 0 && $emptyLabel !== false) {
    array_unshift($options, ['value' => '', 'label' => $emptyLabel]);
}

This brings the option back up to 245.

My guess is that on the travis build the localized country name returned by $this->_localeLists->getCountryTranslation($data['value']); is not null.
Locally the countries \ResourceBundle for the en_US locale doesn't seem to contain that country name. The question is, why? And should the test fail if that is the case?

The address form actually is being built correctly, so I think not. The issue should probably be covered by a test for \Magento\Framework\Locale\TranslatedLists::getCountryTranslation().

[Vinai]

Okay, this version of the test passes locally and on travis. The PR reduces the scope of the test to just check the country options get rendered in the form. Accepting this PR would help keeping other CI pipelines working out of the box.

[NadiyaS]

Hi @Vinai ,
thank you for your contribution. Internal ticket MAGETWO-54783 was created to process your PR.