Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes invalid json objects in the order email templates. #5116

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Fixes invalid json objects in the order email templates. #5116

merged 1 commit into from
Aug 12, 2016

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Jun 20, 2016

This fixes a regression introduced in Magento 2.1-rc1.
Because of the invalid json objects, these email templates couldn't be loaded anymore in the backend of Magento.
Fixes #5101

@hostep hostep mentioned this pull request Jun 20, 2016
Closed
@wert2all wert2all self-assigned this Jun 23, 2016
@NadiyaS NadiyaS self-assigned this Jun 27, 2016
@NadiyaS
Copy link
Contributor

NadiyaS commented Jun 27, 2016

Hi @hostep ,
thank you for your contribution. Internal ticket MAGETWO-54786 was created to process your PR

@NadiyaS NadiyaS added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 27, 2016
@Crossmotion
Copy link
Contributor

This issue still persists in Magento 2.1. Please merge this fix ASAP!

@vkorotun vkorotun added Component: Sales bug report bugfix and removed bug report CS Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 3, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@mmansoor-magento mmansoor-magento merged commit 236257d into magento:develop Aug 12, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54786: [GITHUB] Fixes invalid json objects in the order email…
02bc3fc 
… templates #5116
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-54786: [GITHUB] Fixes invalid json objects in the order email…
6c3a034 
… templates #5116
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@blizam blizam mentioned this pull request Aug 27, 2016
Closed
@Blackskyliner Blackskyliner mentioned this pull request Sep 1, 2016
Closed
@hostep hostep mentioned this pull request Oct 8, 2016
Closed
@veloraven
Copy link
Contributor

Separate internal issue for ver. 2.1 - MAGETWO-57026

@NadiyaS NadiyaS removed their assignment Oct 10, 2016
@veloraven veloraven mentioned this pull request Oct 10, 2016
Closed
@olysenko olysenko mentioned this pull request Nov 2, 2016
Closed
@razbakov razbakov mentioned this pull request Nov 16, 2016
Closed
@hostep hostep mentioned this pull request Dec 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wert2all wert2all

Labels
bugfix Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hostep @NadiyaS @Crossmotion @veloraven @vkublytskyi @mmansoor-magento @wert2all @vkorotun @MomotenkoNatalia @sshrewz