Make CMS directive filtering error be more generic #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Even though the filter method is in the \Magento\Email\Model\Template\Filter class, that class is extended by several CMS classes
|
Magento / @vkorotun This is a simple pull request. Any update on when it can be merged? |
|
@erikhansen finally merged! Better later than never, but I'm sure next time it will be faster. Thank you for the contribution. |
|
@vrann Glad you're making progress through your backlog of PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a site is in production mode and a CMS widget has an error in processing, this error message will be displayed:
We're sorry, an error has occurred while generating this email.Since the \Magento\Email\Model\Template\Filter::filter method is inherited by several CMS classes (
\Magento\Cms\Model\Template\Filterand\Magento\Widget\Model\Template\Filter), the error message should be changed to something more generic. This pull request changes the error message to:We're sorry, an error has occurred while generating this content.