-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customer Group ID - Product Price #593
Conversation
Changed to an !is_null as it would not enter the IF statement when the Customer Group ID === 0
@drdrak3, thank you for your contribution! I created a ticket for it in the product backlog. We will get back to you once we have it reviewed and processed. |
Sub product discounts use this function separately from the main product. In some cases Sub Products would run a different rule to the main product.
@drdrak3, I just talked to the development team. Could you please provide the use case for this issue? We would like to know what is the impact. |
In this specific case. I wanted to show VIP customer group pricing as well as standard pricing to all customers. $_product->setCustomerGroupId(0); This gets the VIP price fine for all users. |
Hi @drdrak3 thank you for you contribution. Can you please review you PR, and resubmit if it is actual with proper tests. Thank you for you help with Magento2. |
Resolution: reject, due creator inactivity for more then 2 weeks. We are going to implement the update, but we can't accept the PR. |
Suggested update is implemented and available from 0.42.0-beta7. |
…only-cookies [Extensibility] Magetwo 41967 httponly cookies
Changed to an !is_null as it would not enter the IF statement when the Customer Group ID === 0