-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change commit to rollBack on fail #6266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suppose we should rollback transaction before exception. We are in the loop and we should not commit partial result on error or we should not use transaction at all.
There is an error "The class StockManagement has a coupling between objects value of 13." related to the changes:
|
Set wrong return type back to eliminate static analyze error.
I have reverted return type of the `getResource()` to the wrong original value but static analyze error still exists. I wrote right value for return type of the method back because this analyze error is not related to my fixes.
@flancer64 thank you for the fix. Don't worry about the static test. We can process this PR without green static test because the failure was not caused by your fix. |
magento-team
pushed a commit
that referenced
this pull request
Apr 19, 2017
@flancer64 thank you for your contribution |
@magento-team This isn't included in 2.2.7. Why Not? |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 22, 2020
…-magento2-30565 [Imported] magento/magento2-page-builder#558: Developer can style content types …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose we should rollback transaction before exception. We are in the loop and we should not commit partial result on error or we should not use transaction at all.