Refactor Option ResourceModel to allow price supporting types to be intercepted #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntercepted This commit allows the price and price_type functionality to be expanded by third party modules with no real change in the logic utilized.
magento-team
pushed a commit
that referenced
this pull request
Apr 13, 2017
…g types to be intercepted #6443
|
@navarr Thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the price and price_type functionality to be expanded by third party modules with no real change in the logic utilized.
This is one of many options - but I feel like it's the one that requires the least thought. Utilizing this methodology anyone can write an interceptor to obtain this functionality for a third-party custom option.
Additional options, such as through XML or other means exist but require more thought and change the underlying behavior - while simply pulling these out into their own function does not.
This PR is intended to be the smallest possible change that improves the extensibility of core. As it is not an [@]API class it can be removed, changed, etc in the future without "bc breaks".