Changed constructor to use interface instead of direct classname #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructor should use an interface instead of a direct classname so it can be overwritten when necessary. In the di.xml this was already done, but in this constructor it didn't use the interface yet, so this has been changed.
|
@dverkade Thank you for the contribution, this PR make our codebase closer to both SOLID principles and Magento Technical Vision, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor should use an interface instead of a direct classname so it can be overwritten when necessary. In the di.xml this was already done, but in this constructor it didn't use the interface yet, so this has been changed.