Move cache to instance of price box widget #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When caches are shared on the class of the price box widget, there can be a case where price boxes are displayed on the page which do not share the same values that should be stored in that cache. For instance, upsells and related products can have price boxes in them, and they will overwrite the cache of the price box on the product page. This change moves the cache off of the class itself and onto the instance so instances of price box widgets don't interfere with one another.
JamesonNetworks
force-pushed
the
bugfix/fix_price_box_widgets_sharing_cache
branch
from
8d6fd29 to
d807789
Compare
|
Closed and reopened to trigger new CI build |
|
@JamesonNetworks successfully merged, thank you for the contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 23, 2021
[Jet] Fixes for 2.4 (pr1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caches are shared on the class of the price box widget, there can
be a case where price boxes are displayed on the page which do not share
the same values that should be stored in that cache. For instance,
upsells and related products can have price boxes in them, and they will
overwrite the cache of the price box on the product page. This change
moves the cache off of the class itself and onto the instance so
instances of price box widgets don't interfere with one another.