Removed commented out line for ignoring coding standards #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed commented out line for ignoring coding standards, this line should not be in the code and is removed for cleaner more readable code.
|
There is more than one occurrence of such annotation in source code currently. At some point a huge mistake was made and instead of automatic fix of PSR-2 violations all problematic files were just excluded from coding style check. To fix this You can see that after you restored coding style check, static test started to fail: https://travis-ci.org/magento/magento2/jobs/165630323 This error is easy to fix but not automatically. |
Changed line length so that the @ignoreCodingStandard which was removed will not throw an exception anymore.
|
@dverkade Appreciate your participation in the Magento community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed commented out line for ignoring coding standards, this line should not be in the code and is removed for cleaner more readable code.