Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed calling non exists order address->getCountry to getCountryId #6974

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Fixed calling non exists order address->getCountry to getCountryId #6974

merged 1 commit into from
Nov 28, 2016

Conversation

krejcif
Copy link
Contributor

@krejcif krejcif commented Oct 12, 2016 •
edited
Loading

Problem occurs when Authorize.net AVS is checking card holder against country which is blank.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 12, 2016 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@YevSent YevSent added the develop label Nov 2, 2016
@YevSent
Copy link
Contributor

YevSent commented Nov 2, 2016

Hi, @magexo, thanks for your fix.
Could you cover your changes in \Magento\Authorizenet\Model\Directpost::capture and \Magento\Authorizenet\Model\Directpost\Request::setDataFromOrder by integration tests?

@krejcif
Copy link
Contributor Author

krejcif commented Nov 2, 2016

Sorry, there are no resources for that.

@mmansoor-magento mmansoor-magento merged commit 18da140 into magento:develop Nov 28, 2016
@Ctucker9233
Copy link

Still not included in 2.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alena-marchenko alena-marchenko

Labels
Component: Payment Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@krejcif @magento-cicd2 @YevSent @Ctucker9233 @vkublytskyi @vasiliyseleznev @mmansoor-magento @alena-marchenko