Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where it isn't possible to skip url validation when using cons... #703

Closed

Conversation

Marko-M
Copy link
Contributor

@Marko-M Marko-M commented Oct 24, 2014

With current alpha 100 there is a regression due to which it currently isn't possible to skip URL validation using -"--skip_url_validation yes" console parameter when using console installer. This commit fixes the issue for current alpha, but since goals of code creating regression are unclear to me, this might require additional attention.

@Marko-M
Copy link
Contributor Author

Marko-M commented Oct 25, 2014

Additional information, although issue exists always, it becomes visible only when document root is set to /pub because then Magento for some reason doesn't manage to redirect to new setup installer thus URL validation fails. This means that out the box at my setup, when document root is set to /pub, it isn't possible to install Magento since neither console nor web setup works. Can someone confirm this?

@buskamuza
Copy link
Contributor

Hi @Marko-M , this installer is going to be removed soon.
Please, try new installer in Setup Tools (setup folder):

php -f setup/index.php install --db_host=localhost --db_name=magento2 --db_user=root --db_pass=password --backend_frontname=admin --base_url=http://magento2.lh/ --language=en_US --timezone=America/Chicago --currency=USD --admin_lastname=admin --admin_firstname=admin --admin_email=a@m.com --admin_username=admin --admin_password=123123q --use_secure=0

Update with necessary values.
Run composer install in setup directory before running the tool.

@Marko-M
Copy link
Contributor Author

Marko-M commented Oct 26, 2014

Hello @buskamuza,
thanks for your response, much appreciated. I confirm that console install using new setup tool works well just like you outlined. Issue that remains is that web setup of the same tool has redirect loop when having web server document root set to magento_directory/pub, I guess it's due to work being currently done at new setup code, but just so it doesn't get unnoticed.

@buskamuza
Copy link
Contributor

Thanks @Marko-M , we'll check the case with redirect loop.

@Marko-M Marko-M closed this Nov 1, 2014
@Marko-M Marko-M deleted the bugfix/install-skip-url-validation branch November 1, 2014 20:49
MomotenkoNatalia pushed a commit that referenced this pull request Oct 21, 2015
magento-team pushed a commit that referenced this pull request Oct 5, 2017
Bug fixes:
- MAGETWO-61112: [Backport] [github #6195, #4101] Gallery doesn't show all images added to configurable options
- MAGETWO-61326: [Backport] State/Province dropdown is broken in frontend customer gift registry
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this pull request Apr 6, 2018
…n-Test-for-adding-product-into-the-shopping-cart

MSI-688: Fixed add to cart tests
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
…functionality magento#703

 - Merge Pull Request magento/graphql-ce#703 from magento/graphql-ce:graphql-484
 - Merged commits:
   1. 468767e
   2. 138ecb4
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants