Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Mage_Sales_Model_Order_Invoice_Total_Shipping:50 #72

Closed

Commits on Aug 10, 2012

  1. Validation change for Text type attributes.

    The call on Mage_Eav_Model_Attribute_Data_Text:67 to empty returns true of a value of "0" is entered, as specified in the PHP spec. This prevents the entry of zero on the backend admin for fields. Zero should be a valid value, as it was in our case.
    
    No unit tests were created, as no unit tests exist currently for the Eav module.
    tim-reynolds committed Aug 10, 2012
    Configuration menu
    Copy the full SHA
    368e2b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2012

  1. Configuration menu
    Copy the full SHA
    74a8a32 View commit details
    Browse the repository at this point in the history
  2. Unit test created for previous commit (368e2b6)

    Sorry for not including this originally.
    tim-reynolds committed Aug 12, 2012
    Configuration menu
    Copy the full SHA
    951423a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0f7857 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2012

  1. Configuration menu
    Copy the full SHA
    54a9f56 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2012

  1. Bug - Mage_Sales_Model_Order_Invoice_Total_Shipping:50

    The line was
    if($previusInvoice->getShippingAmount() && ...
    This would return true if a previous invoice had zero shipping because it was returned as a string from the database. The string "0.0000". The line needs to be changed to have a greaterthan comparison to cause the string to cast to a numeric.
    
    Also added unit test.
    tim-reynolds committed Aug 30, 2012
    Configuration menu
    Copy the full SHA
    697ad8e View commit details
    Browse the repository at this point in the history
  2. Bug - Mage_Sales_Model_Order_Invoice_Total_Shipping:50

    The line was
    if($previusInvoice->getShippingAmount() && ...
    This would return true if a previous invoice had zero shipping because it was returned as a string from the database. The string "0.0000". The line needs to be changed to have a greaterthan comparison to cause the string to cast to a numeric.
    
    Also added unit test.
    
    Added comments
    tim-reynolds committed Aug 30, 2012
    Configuration menu
    Copy the full SHA
    2aadc56 View commit details
    Browse the repository at this point in the history