Added "Add / update" comment. Update was missing. #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have the same description as in CartItemRepositoryInterface.php. Currently only says add, but the API works for add and update too.
|
"Added "Add / update" comment. Update was missing." was the original title of the post, changed it to notice travis error. |
gastondisacco
changed the title
|
Hi, I have head the same problem. The build is failling on calling a URL for fetching the exchange rates. I have rebased my commit a couple of times and finally it passed. You might want to try this as well. |
|
Hi @dverkade, thanks for your comment! Will try again so. |
gastondisacco
changed the title
davidalger
approved these changes
Mar 16, 2017
|
@gastondisacco thank you for your contribution! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 11, 2022
L3 arrows pr 20220329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have the same description as in CartItemRepositoryInterface.php.
Currently only says add, but the API works for add and update too.