Fix test assertion #755
Closed
Fix test assertion #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Vinai, if you still interested in processing this PR, can you please resubmit it to develop branch, and also re-run test? Thanks, Max. |
* Fix test assertion in View\Layout\Reader\UiComponentTest * Refactor so the test name matches the changes in the code
mmansoor-magento
pushed a commit
that referenced
this pull request
Jan 20, 2017
[Epam] Extend functional test coverage 3 - Task: - MTO-3: [Test] Create test for CMS page mass grid functionality - MTO-6: [Variation] Add variation to Update Downloadable Product test to verify data overriding on Store View level - MTO-8: Add variation to create category test with a big nesting level - MTO-14: [Variation] Add variation to update Category on Store View level - MTO-15: [Variation] Manage customers via mass action - MTO-31: [Constraint] Verify auto-generate Request Path for product which is assigned to subcategory - MTO-34: [Constraint] Verify that product quantity is decreased after placing an order - MTO-36: [Constraint] Verify that product can be added to shopping cart from search page - MTO-38: [Constraint] Update synonym group search in a grid - MTO-39: [Test] Create multiple synonyms groups - MTO-45: [Constraint] Assert product can be found using advanced search - MTO-47: [Constraint] Assert item count in mini shopping cart - MTO-48: [Variation] Verify that first name and last name are put to address while checkout - MTO-49: [Test] Sales shipping report - MTO-51: [Variation] Product advanced inventory - MTO-52: [Constraint] Assert shopping cart sidebar - MTO-54: [Test] Shopping Cart and Mini Shopping Cart per Customer - MTO-66: [Variation] No XSS injection on Update User Account - MTO-72: [Variation] Use sorting category filter for applied layered navigation - MTO-73: Catalog Rules Indexer - MTO-79: [Variation] Autocreate URL Rewrite for a Product with Several Websites and Different Root Categories - MTO-80: [Constraint] Verify URL rewrite for nesting category - MTO-82: [Variation] Edit category to check URL rewrites - MTO-86: [Test] Cache invalidation when products website visibility change - MTO-87: [Test] Page cache for different CMS pages on multiple store views - MTO-90: [Test] Reports Refresh statistics - MTO-91: [Test] Url rewrites in catalog categories after changing url key for store view and moving category - MTO-97: [Test] Unlock Admin User - MTO-98: [Variation] Do Advanced Search without entering data
magento-engcom-team
added a commit
that referenced
this pull request
Jul 11, 2019
- Merge Pull Request magento/graphql-ce#755 from pmclain/graphql-ce:issue/740 - Merged commits: 1. b0f98b4
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original assertion simply stubbed the setStructureElementData method on the View\Layout\ScheduledStructure\Helper mock. The method in question is not part of the helper interface but of the View\Layout\ScheduledStructure interface.
The change moves the assertion to the scheduled structure mock and changes the expectation from any() to once().