Reset skippedRows array in clear method #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added skippedRows array in clear method, missing to clear this array can cause an issue when you programmatically import more than one file, especially in a foreach loop because this object is treated as singleton. In this case, in the next file of your loop, magento checks for skipped rows and skips rows based on previous file. A pseudo-code example is following:
$files = ['file1.csv', 'file2.csv'];
foreach ($files as $file) {
.... // validate file
.... // import file
// if some file has skipped rows, skippedRows array is persistent between all files because is not cleared with clear() method called in validateData() method
}
|
|
|
@ccasciotti thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added skippedRows array in clear method, missing to clear this array can cause an issue when you programmatically import more than one file, especially in a foreach loop because this object is treated as singleton. In this case, in the next file of your loop, magento checks for skipped rows and skips rows based on previous file. A pseudo-code example is following:
$files = ['file1.csv', 'file2.csv'];foreach ($files as $file) {.... // validate file.... // import file// if some file has skipped rows, skippedRows array is persistent between all files because is not cleared with clear() method called in validateData() method}