Add host header to varnish cache purge request #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done in accordance to RFC 7230 which states (in part): “A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field…”
Accounts for the addition of the host header in the purge request.
|
Not sure why the second travis build failed, should I submit a new PR or can it be restarted? |
|
@m0zziter I have the same issue. Same tests failed. It is possible that dev branch doesn't pass build anymore. |
Merged
|
Haven't heard anything from the magento team on this yet. Is there anything else y'all need me to do? If so, let me know and I'd be happy to do whatever's necessary. |
This was done in accordance to RFC 7230 which states (in part): “A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field…”
Accounts for the addition of the host header in the purge request.
|
@m0zziter PR is merged, thank you! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Aug 10, 2022
…ync-05172022 Sync of 2.4.5-develop with 2.4-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done in accordance to RFC 7230 which states (in part): “A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field…”
Fixes #7614