Update Queue.php #7771
Closed
Update Queue.php #7771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 2 items were backwards. After spending hours troubleshooting why my newsletter was being rejected by my mail host i tracked it back to this.
|
|
|
@cbarsness Would be great to cover this case with unit test in order to prevent such situations in future |
antonkril
approved these changes
Jan 10, 2017
|
Closing this pull request. Source branch was removed |
|
@okorshenko why? It looks like bug is still present in Changes can be obtained with Of course, probability that PR author will make any changes if it is required is low when source branch is removed, my two cents is that it's better to pick and process good PR in its current state than just close. |
|
Looks like this was recently fixed by #6354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 items were backwards. After spending hours troubleshooting why my newsletter was being rejected by my mail host i tracked it back to this.