Type cast #8077
Merged
Type cast #8077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typecast the $this->_getAllowedCurrencies() to an array so that single string responses don't break the logical checks
Fixed: Something went wrong while saving this configuration: Warning: in_array() expects parameter 2 to be array, string given in /opt/vaimo/deploy/x7642/2017-01-09_13-38-36/htdocs/vendor/magento/module-config/Model/Config/Backend/Currency/DefaultCurrency.php on line 30
|
|
antonkril
suggested changes
Jan 10, 2017
|
Thanks @antonkril for your feedback. I have updated the method as requested. |
antonkril
approved these changes
Jan 10, 2017
antonkril
approved these changes
Jan 24, 2017
maghamed
approved these changes
Feb 13, 2017
|
@deriknel thank you for your contribution and bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Report: #8076
Typecast the
$this->_getAllowedCurrencies()in the Allow.php and DefaultCurrency.php under Config/Currency to fix this error:Something went wrong while saving this configuration: Warning: in_array() expects parameter 2 to be array, string given in /var/www/clean-m2-ee/vendor/magento/module-config/Model/Config/Backend/Currency/DefaultCurrency.php on line 30