Throw exception for invalid (missing) template in dev mode

[convenient]

In developer mode php notices/warnings etc are promoted to being exceptions. This means the developer is a bit more diligent with cleaning up any messes as they occur. This does not seem to apply to layout declarations with invalid templates.

I noticed this error on a Magento 1 client which is filled with "Not valid template file", I checked in M2 and this error seems to persist. Developer mode does not promote invalid template errors to being an exception.

This change should make sure developers do not leave any dead templates in their layout.xml. It seems like an easy win to me.

Don't we all want clean log files? :)

[vrann]

Please use \Magento\Framework\Exception\ValidatorException instead

[vrann]

@convenient Thanks for the contribution, it definitely makes sense to output exception rather way for the developer so there is insensitive to fix it.

Added comment to the code review, please process.

[convenient]

Updates pushed, @vrann Is that alright mate?

[vrann]

@convenient perfect, thanks!

[convenient]

Awesome thanks @vrann.

I wonder how much screaming there is going to be

Boo the latest magento version breaks when using developer mode what happened?

[vrann]

@convenient wait, what was the intent of PR? Checking \Magento\Framework\View\Element\Template\File\Validator::isValid method, it will check only for template being in the right location. Have you meant to throw the exception in case if a template has syntax errors?

public function isValid($filename)
    {
        $filename = str_replace('\\', '/', $filename);
        if (!isset($this->_templatesValidationResults[$filename])) {
            $this->_templatesValidationResults[$filename] =
                ($this->isPathInDirectories($filename, $this->_compiledDir)
                    || $this->isPathInDirectories($filename, $this->moduleDirs)
                    || $this->isPathInDirectories($filename, $this->_themesDir)
                    || $this->_isAllowSymlinks)
                && $this->getRootDirectory()->isFile($this->getRootDirectory()->getRelativePath($filename));
        }
        return $this->_templatesValidationResults[$filename];
    }

[vrann]

@convenient or is that exactly what happens when you leave the dead template in the layout? Yeah, then we might hear boos :) (in developer mode only)

[convenient]

I meant the latter. I'm wondering how many dead templates exist in m2 websites today, quietly logging away never being cleaned up.

We'll find out when this is released and the developers start to complain I guess.

[okorshenko]

@convenient thank you for your contribution