Update Options.php #8130
Merged
Update Options.php #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent special charachters (like ü or ß) from being inserted as HTML encoded entities (like ü or ß) in widget input fields.
vrann
suggested changes
Mar 1, 2017
| @@ -163,6 +163,8 @@ protected function _addField($parameter) | |||
| } | |||
| } | |||
|
|
|||
| $data['value'] = html_entity_decode( $data['value'] ); | |||
There was a problem hiding this comment.
- Please use \Magento\Framework\Escaper::escapeHtmlAttr instead of native PHP library
- there is extra space after "(", please remove
There was a problem hiding this comment.
The \Magento\Framework\Escaper::escapeHtmlAttr function doesn't give the desired result. html_entity_decode is used by Magento core elsewhere. See https://github.com/magento/magento2/search?utf8=✓&q=html_entity_decode&type=Code. I have removed the extra spaces.
|
@redelschaap Thank you for the contribution! Left couple comments in the code review. |
Removed spaces
vrann
approved these changes
Mar 13, 2017
|
@redelschaap merged! Appreciate your support. |
|
Great! Thanks! |
|
@vrann @redelschaap |
|
Than that value is serialized, so it will be a string on that point. Right @vrann? |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 13, 2023
L3 Bugfix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent special charachters (like ü or ß) from being inserted as HTML encoded entities (like ü or ß) in widget input fields.