Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "<2.7" constraint on symfony/console #8151

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Remove "<2.7" constraint on symfony/console #8151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"tubalmartin/cssmin": "2.4.8-p4",
"magento/magento-composer-installer": ">=0.1.11",
"braintree/braintree_php": "3.7.0",
"symfony/console": "~2.3 <2.7",
"symfony/console": "~2.3",
Copy link
Contributor

@okorshenko okorshenko Feb 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to avoid issue with depreciation exceptions from Symfony code I'd recommend change this dependency in the following way:

"symfony/console": "~2.3, !=2.7.0",

This issue was introduced in 2.7.0 and was fixed in 2.7.1

bug #14900 Silence deprecation warnings by default (reecefowell)

So we would like to avoid using of problematic version
Thank you for your efforts!

"symfony/event-dispatcher": "~2.1",
"symfony/process": "~2.1",
"phpseclib/phpseclib": "2.0.*",
Expand Down