Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixed the credit memo guest email #8183

Merged
merged 3 commits into from
Feb 2, 2017

Conversation

nickgraz
Copy link
Contributor

The credit memo guest email had a typo where the Order ID is generated.

To reproduce:

  1. Set up Magento2 base installation
  2. Order a product and checkout as guest on the front end
  3. Refund the purchase in the back end, creating a credit memo

Expected result:
Guest gets credit memo email with Order ID

Actual result:
Guest gets credit memo email without Order ID

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 18, 2017

CLA assistant check
All committers have signed the CLA.

@hostep
Copy link
Contributor

hostep commented Jan 18, 2017

Nice find!

Maybe also consider patching the email template in the luma theme, it has the same problem:
https://github.com/magento/magento2/blob/eb30343/app/design/frontend/Magento/luma/Magento_Sales/email/creditmemo_new_guest.html#L36

@nickgraz
Copy link
Contributor Author

@hostep Good point! I added another commit to this PR.

@teyou
Copy link

teyou commented Jan 23, 2017

#7708

sent same PR, they never merge it...

@ishakhsuvarov ishakhsuvarov self-assigned this Feb 1, 2017
@mmansoor-magento mmansoor-magento merged commit cb4033e into magento:develop Feb 2, 2017
@okorshenko
Copy link
Contributor

Thank you for contribution to Magento 2 project!

@Ctucker9233
Copy link

@okobchenko Can we get this into 2.1. asap? I just checked on 2.1.10 and the typo is still there.

magento-devops-reposync-svc pushed a commit that referenced this pull request Mar 2, 2023
[Bluetooth] Community Pull Requests delivery - 2.4-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants