Fix notice during DI compilation #8232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an interface has a constructor on it, `getConstructor()` for a ReflectionClass object of it will be null and cause this: ``` [Exception] Notice: Trying to get property of non-object in /Users/cristianquiroz/src/magento2/vendor/magento/framework/Code/Reader/ArgumentsReader.php on line 30 ``` Magento shouldn't pull any dependencies from interface constructors anyway, they will need to be properly implemented before they can be used.
|
|
qrz-io
added a commit
to AmpersandHQ/web-service-common-php
that referenced
this pull request
Jan 23, 2017
We do this to make this package compatible with M2 DI compile. See magento/magento2#8232
ishakhsuvarov
requested review from
maghamed
and removed request for
antonkril
|
@qrz-io Pull Request had been delivered to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an interface has a constructor on it,
getConstructor()for a ReflectionClass object of it will be null and cause this:Magento shouldn't pull any dependencies from interface constructors anyway, they will need to be properly implemented before they can be used.
Steps to reproduce
php bin/magento setup:di:compileExpected results
Success
Actual results