Use better function for 'Continue Shopping' url #8341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added 4 commits
January 31, 2017 08:25
Fix line exceeded max length issue. Use ::class syntax.
|
Thank you for contribution to Magento 2 project! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jul 15, 2023
[L3 Kings] Bugfix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Continue Shopping' url on the checkout success page is basically hard-coded to be the store base url because it just calls Magento\Framework\View\Element\AbstractBlock::getUrl() without any parameters. This means a developer would need to override the module-checkout/view/frontend/templates/success.phtml file completely in order to change the url.
I propose creating a getContinueUrl function in the Magento\Checkout\Block\Onepage\Success class that would allow developers a way to change the url for the 'Continue Shopping' button by using a plugin instead of needing to override a core template, which is bad practice. The Magento_Multishipping module already does this for its success page 'Continue Shopping' url, so I mostly copied that implementation.