Issue/8382 #8383
Merged
Issue/8382 #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PascalBrouwers Thanks! can you please squash all commits and provide one commit with the meaningful description |
|
@PascalBrouwers also, another discussion item. Can you change the version of monolog dependency in your project composer.json file? Should it really be done for all Magento application? My concern is that if some other Magento component depends on version 1.16, it will be broken with this change. |
|
Hi @vrann I'll squash those commits and edit the description. Let me check if any modules depend of 1.16 specifically. |
PascalBrouwers
force-pushed
the
issue/8382
branch
from
11a2e55 to
9ca160f
Compare
|
@PascalBrouwers thank you for update. Magento works well with the new version. Accepting |
|
@PascalBrouwers Thank you for your contribution to Magento 2 project! Your pull request has been successfully merged! |
paales
added
the
Partner: Reach Digital
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.