Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed name of dispatched object in delete event #8445

Merged
merged 3 commits into from
Mar 21, 2017

Conversation

clementbeudot
Copy link
Contributor

@clementbeudot clementbeudot commented Feb 7, 2017

in catalog_category_delete_after_done event dispatch in delete method (:1020)
changed dispatched object name from "product" to "category"

in catalog_category_delete_after_done event dispatch in delete method (:1020)
changed dispatched object name from "product" to "category"
@ishakhsuvarov
Copy link
Contributor

@clementbeudot Hi! Thank you for your contribution.
Unfortunately we can not accept this kind of change, since some extension or customization potentially may rely on that naming convention. In this case such rename may cause unexpected behavior or errors.

@clementbeudot
Copy link
Contributor Author

Ok thank you. I know that it could potentially break something. But it is really strange to obtain a "product" when expecting a "category".

Maybe something to change later.

@ishakhsuvarov
Copy link
Contributor

@clementbeudot
Thats true, however too risky for now. Thanks for understanding.

@fooman
Copy link
Contributor

fooman commented Feb 7, 2017

Maybe it could add the product additionally as that would not break existing and add a deprecation notice on the category?

@clementbeudot
Copy link
Contributor Author

hey @fooman, good idea as it would not break anything and people who are trying to use this event won't be stuck finding out why there is no "category" object passed in the event.

Left the 'product' key to avoid breaking extensions.
@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@maksek maksek modified the milestones: February 2017, March 2017 Mar 1, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 1, 2017
@magento-team magento-team merged commit cf4332f into magento:develop Mar 21, 2017
@vrann
Copy link
Contributor

vrann commented Mar 21, 2017

@clementbeudot Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants