-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed name of dispatched object in delete event #8445
Conversation
in catalog_category_delete_after_done event dispatch in delete method (:1020) changed dispatched object name from "product" to "category"
@clementbeudot Hi! Thank you for your contribution. |
Ok thank you. I know that it could potentially break something. But it is really strange to obtain a "product" when expecting a "category". Maybe something to change later. |
@clementbeudot |
Maybe it could add the product additionally as that would not break existing and add a deprecation notice on the category? |
hey @fooman, good idea as it would not break anything and people who are trying to use this event won't be stuck finding out why there is no "category" object passed in the event. |
Left the 'product' key to avoid breaking extensions.
@clementbeudot Thank you for the contribution! |
in catalog_category_delete_after_done event dispatch in delete method (:1020)
changed dispatched object name from "product" to "category"