Feature: Magento\Backend\Block\Widget\Grid\Column\Renderer #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currency and Price Renderer: use _getValue() to be able to also retrieve a calculated value instead of a fixed one via getData().
maksek
added
PROD
Issue: Ready for Work
|
Code Review passed |
maksek
removed
the
Issue: Ready for Work
maksek
pushed a commit
that referenced
this pull request
Dec 25, 2014
Feature: Magento\Backend\Block\Widget\Grid\Column\Renderer (MAGETWO-32153)
mmansoor-magento
pushed a commit
that referenced
this pull request
Feb 22, 2017
Fixed issues: - MAGETWO-62616: Products are missed and total count is wrong on category page - MAGETWO-63403: Auto Generated coupon codes not applying - MAGETWO-63561: category_ids attribute scope dropdown - MAGETWO-61830; Related Products Rules can't be defined based on product attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency and Price Renderer: use _getValue() to be able to also
retrieve a calculated value instead of a fixed one via getData().
In Magento\Backend\Block\Widget\Grid\Column\Renderer\Currency the render method is not using
\Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer::_getValue(Object $row)
What is the particular reason for relying on the retrieval method above? ;-)
Would be great if you can implement the
_getValue() method as there are use cases for retrieving a computed value.In
Magento\Backend\Block\Widget\Grid\Column\Renderer::Numberyou have the correct useful implementation of_getValue():-)Thank you for merging!