Fix: various problems with minimum order amount enabled #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See magento#6151 for the basics. When minimum order amount is enabled: 1. add 1 product to the cart; total is below min order amount -> no error. 2. Try to remove that product -> error about minimum amount. 3. Try to add more to the cart with total still below min order -> error about minimum amount 4. Add a product that will bring the total cart amount **over** the min order amount and no errors! I will request the Magento team takes a look at this line. I don't understand why the minimum amount is being validated here but perhaps it has something to do with multi-shipping checkouts. However, it botches the min order amount logic badly in it's current form.
|
@ericrisler thank you for your contribution. Unfortunately the issue exists, but it can't be fixed in proposed way. Closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6151 for the basics.
When minimum order amount is enabled:
I will request the Magento team takes a look at this line. I don't understand why the minimum amount is being validated here but perhaps it has something to do with multi-shipping checkouts. However, it botches the min order amount logic badly in it's current form.