Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active class to search form wrapper for more theming flexibility #8723

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

andrewkett
Copy link
Contributor

@andrewkett andrewkett commented Feb 28, 2017

Currently when the search form is focused I can only theme the search label (because it has an active class) and the input element itself (because it is focused). I cannot currently theme the input wrapping .control div as there are no wrapping elements identifying that the form has been focused.

Adding an active class to the wrapping .minisearch form allows us to theme any children elements when the search form is focused.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 28, 2017

CLA assistant check
All committers have signed the CLA.

@maghamed maghamed self-requested a review March 1, 2017 12:27
@maghamed maghamed self-assigned this Mar 1, 2017
@ishakhsuvarov
Copy link
Contributor

@andrewkett We have now merged the proposed fix into the develop branch. Thank you for contribution!

@Flamestyle
Copy link

Flamestyle commented Jul 24, 2017

@andrewkett, what do you think this problem is related to this script?

Сlicking on the search box does not work on iPad, when I set the width: 0 for input.

Theme Luma, module Search. I want the field to pop out when I click on the icon.

Example without a bug:

Click on the label element and change the position of the input element (the input element shifted). The click works.

Example with a bug:

It is necessary that when the label is clicked, the width of the input element changes (I set the input to width: 0, padding: 0, when the width of the click is set to width: 250px.) Result: the width change on the ipad does not work.

@Ctucker9233
Copy link

@magento-team Can this be backported to 2.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants