Made Topmenu HTML Editable #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksek
added
MX
Issue: Ready for Work
|
|
|
@sprankhub, could you specify in the description what kind of issue are you trying to resolve? It will help us to understand the fix and its valuable. |
|
I assume its so event hook can replace the HTML (by updating the transport object). Otherwise the events can see the HTML, but not replace it. |
|
Exactly @alankent. This is a pattern used in other places in Magento in order to allow the observer to update something (the HTML output of the topmenu in this case). IMHO, the current implementation does not really make sense, because it says "hey, I give you an event with which you can have a look at the HTML, but you cannot do anything with it". This has also been discussed in this Magento SE thread. |
vpelipenko
added
Progress: accept
CS
improvement
and removed
MX
Issue: Ready for Work
|
CR: passed |
vpelipenko
added a commit
that referenced
this pull request
Jan 20, 2015
Made Topmenu HTML Editable (MAGETWO-32828)
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Feb 9, 2015
* UI improvements:
* Updated the design of Enable Cookies CMS page
* Implemented UI improvements for Widgets
* Fixed the "Help Us to Keep Magento Healthy Report All Bugs (ver. #)" link Magento Admin
* Various UI improvements
* Various improvements:
* Implemented Sales Quote as a standalone Magento module
* Performed custom EAV entities code and DB tables cleanup
* Eliminating remnants of the Core module:
* Moved Application Emulation from the Magento_Core module to the Magento_Store module
* Moved Validator Factory from the Magento_Core module to the Magento Framework
* Added static integrity test for composer.json files
* Added PHPMD and PHPCS annotations to the codebase
* Tests improvements:
* Added MVP tag to the functional tests
* Created acceptance functional test suite
* Replaced end-to-end tests for url rewrite creation, CMS page creation, category creation, review creation, customer frontend creation, and tax rule creation with injectable tests
* Automated test cases for downloadable products with taxes
* Fixed bugs:
* Fixed an issue where the Discounts and Coupons RSS Feed had incorrect title
* Fixed an issue where a wrong special price expiration date was displayed in RSS
* Fixed an issue in the Import functionality where imported files disappeared after the Check Data operation
* Fixed an issue where the Unsubscribe link in the Newsletter was broken
* Fixed an issue where stock status changed incorrectly after import
* Fixed an issue where selected filters and exclude did not work during Export
* Fixed an issue where tax details order was different on order/invoice/refund create and view pages (
* Fixed a typo in the getCalculationAlgorithm public function
* Fixed an issue where the incorrect value of Subtotal Including Tax was displayed in invoices
* Fixed an issue where tax details were not displayed on a new order
* Improved pricing performance using caching
* Fixed an issue where CsvImportHandler tests still referring to links from Tax module instead of TaxImportExport module
* Fixed an issue where an exception was thrown instead of 404 if altering the url for a product with required configuration on the storefront
* Fixed an issue where the title of successfully placed order page (was empty
* Fixed an issue where certain fields were not disabled by default on the website scope in System configuration as expected
* Fixed an issue where third party interfaces were not supported by single-tenant compiler
* Eliminated the 'protocol' parameter from the ReadInterface and WriteInterface
* GitHub requests:
* [#979](magento/magento2#979) -- Adding OSL license file name
* [#978](magento/magento2#978) -- Added ignore rule for media assets in wysiwyg directory
* [#877](magento/magento2#877) -- Made Topmenu HTML Editable
* [#906](magento/magento2#906) -- Add tests for View\Layout\Reader\Block and slight refactoring
* [#682](magento/magento2#682) -- \Magento\Framework\Pricing\PriceCurrencyInterface depends on Magento application code
* [#581](magento/magento2#581) -- About ByPercent.php under different currencies
* [#964](magento/magento2#964) -- Improving documentation for jMeter performance tests
* [#871](magento/magento2#871) -- Replace Symfony2/Yaml in composer
* [#990](magento/magento2#990) -- add @see annotation before class to make it recognizable by IDE
* [#988](magento/magento2#988) -- Prevent Varnish from creating cache variations of static files
* Framework improvements:
* Improved unit and integration tests coverage
mmansoor-magento
pushed a commit
that referenced
this pull request
Feb 25, 2017
Public Pull Requests #8677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.