Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#8596: Varnish/ESI breaks on product pages when skus … #8773

Closed
wants to merge 3 commits into from
Closed

magento/magento2#8596: Varnish/ESI breaks on product pages when skus … #8773

wants to merge 3 commits into from

Conversation

mcspronko
Copy link
Contributor

@mcspronko mcspronko commented Mar 2, 2017 •
edited by okorshenko
Loading

…have slashes

  • added base64_encode function for handles to support /

@mcspronko
#8596: Varnish/ESI breaks on product pages when skus have slashes
dff5270 
 - added base64_encode function for handles to support /
@okorshenko
Copy link
Contributor

Hi @mcspronko
Could you please resolve the code conflict so that we can process this RP?

@okorshenko okorshenko self-assigned this Mar 2, 2017
@mcspronko
Copy link
Contributor Author

Hi @okorshenko

Yes, no problem.

mcspronko added 2 commits March 2, 2017 23:47
@mcspronko
Merge remote-tracking branch 'mage/develop' into develop4
18507a1 
# Conflicts:
#	app/code/Magento/PageCache/Observer/ProcessLayoutRenderElement.php
@mcspronko
#8644: Sitemap bad urls: http//, but must bee https//
ae536cf 
 - fixed test
@mcspronko
Copy link
Contributor Author

@okorshenko please check now.

@okorshenko okorshenko mentioned this pull request Mar 3, 2017
Merged
@okorshenko
Copy link
Contributor

Will be delivered in scope of #8769

@okorshenko okorshenko added this to the March 2017 milestone Mar 3, 2017
@okorshenko okorshenko closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bugfix duplicate Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
2 participants
@mcspronko @okorshenko