Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#8871: Typo in Pull Request Template #8908

Merged
merged 1 commit into from
Mar 23, 2017
Merged

magento/magento2#8871: Typo in Pull Request Template #8908

merged 1 commit into from
Mar 23, 2017

Conversation

tomislavsantek
Copy link

@tomislavsantek tomislavsantek commented Mar 16, 2017 •
edited by ishakhsuvarov
Loading

  • Fixed the typo

Description

Replaced occurrences of magetno with magento in the file PULL_REQUEST_TEMPLATE.md

Fixed Issues (if relevant)

  1. Typo in Pull Request Template #8871: Typo in Pull Request Template

Manual testing scenarios

  1. check the file PULL_REQUEST_TEMPLATE for occurence of typo "magetno"

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 16, 2017
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 16, 2017
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 16, 2017 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@ishakhsuvarov
Copy link
Contributor

Hi @tomislavsantek
Please sign our Contributor License Agreement (CLA) so we can proceed with accepting your contribution.
Thanks!

@tomislavsantek
Copy link
Author

@ishakhsuvarov CLA signed.

@ishakhsuvarov
Copy link
Contributor

Hi @tomislavsantek
CLA check is still displayed as pending. Please make sure you have added your email address you used for the commit into github profile and try again.

Thank you!

@magento-team magento-team merged commit 64a471a into magento:develop Mar 23, 2017
@ishakhsuvarov
Copy link
Contributor

@tomislavsantek Thank you for your contribution

magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 28, 2024
@internal-magento-queue-manager
Merge pull request #8908 from magento-gl/UPS_AC11811_29APR
493e01f 
Hammer:: Platform Health Scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@tomislavsantek @magento-cicd2 @ishakhsuvarov @magento-team @okorshenko @dev-i-WaysHR