Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check of null result value in swatch-renderer.js #8923

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Check of null result value in swatch-renderer.js #8923

merged 1 commit into from
Mar 31, 2017

Conversation

aholovan
Copy link
Contributor

@aholovan aholovan commented Mar 17, 2017 •
edited by okorshenko
Loading

Check of null result value in swatch-renderer.js

Description

There is an error when product has more than one kind of swatches:
Uncaught TypeError: Cannot read property 'oldPrice' of undefined - swatch-renderer.js:843

Manual testing scenarios

  1. Set Special Price for some Simple of the Configurable product which has more than one kind of swatches, for example SKU: WJ03
  2. Go to PDP (../augusta-pullover-jacket.html)
  3. Select some Color and look to the console - there You will be able to see the error. This is because 'result' is null before all of the swatches are selected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@aholovan
Check of null result value in swatch-renderer.js
269c215 
There is an error when product has more than one kind of swatches:
Uncaught TypeError: Cannot read property 'oldPrice' of undefined - swatch-renderer.js:843

Steps to reproduce:
1) Set Special Price for some Simple of the Configurable product which has more than one kind of swatches, for example SKU: WJ03
2) Go to PDP (../augusta-pullover-jacket.html)
3) Select some Color and look to the console - there You will be able to see the error. This is because 'result' is null before all of the swatches are selected.
@aholovan aholovan mentioned this pull request Mar 17, 2017
Closed
@aholovan aholovan changed the title Check of null result value in swatch-renderer.js magento/magento2#8923 Check of null result value in swatch-renderer.js Mar 17, 2017
@aholovan aholovan changed the title magento/magento2#8923 Check of null result value in swatch-renderer.js magento/magento2#8923: Check of null result value in swatch-renderer.js Mar 17, 2017
@okorshenko okorshenko self-assigned this Mar 17, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 17, 2017
@okorshenko okorshenko changed the title magento/magento2#8923: Check of null result value in swatch-renderer.js Check of null result value in swatch-renderer.js Mar 17, 2017
@magento-team magento-team merged commit 269c215 into magento:develop Mar 31, 2017
magento-team pushed a commit that referenced this pull request Mar 31, 2017
MAGETWO-66321: Check of null result value in swatch-renderer.js #8923
6001299
@okorshenko
Copy link
Contributor

@aholovan thank you for your contribution!

@aholovan aholovan mentioned this pull request Jun 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
improvement Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@aholovan @okorshenko @magento-team