Fixed empty submenu group in backend menu #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vovayatsyuk |
|
Done. |
|
@vovayatsyuk Thank you. |
magento-team
pushed a commit
that referenced
this pull request
Mar 25, 2017
|
@vovayatsyuk Thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes empty submenu groups in case if group is added by one module and items inserted with another one, but customer disable it.
Manual testing scenarios
Open app/code/Magento/Customer/etc/adminhtml/menu.xml
Remove "Magento_Customer::customer_group" item
Navigate to backend and see "Stores" menu. ("Other setting" submenu looks bad and it's useless):
Contribution checklist