Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5627: main.CRITICAL: Broken reference (Magento CE v2.1) #9092

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Issue #5627: main.CRITICAL: Broken reference (Magento CE v2.1) #9092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/View/Layout/Data/Structure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public function reorderChildElement($parentName, $childName, $offsetOrSibling, $
$siblingParentName = $this->getParentId($sibling);
if ($parentName !== $siblingParentName) {
if ($this->state->getMode() === State::MODE_DEVELOPER) {
$this->logger->critical(
$this->logger->info(
"Broken reference: the '{$childName}' tries to reorder itself towards '{$sibling}', but " .
"their parents are different: '{$parentName}' and '{$siblingParentName}' respectively."
);
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/View/Layout/ScheduledStructure/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public function scheduleElement(
$scheduledStructure->setElementToBrokenParentList($key);

if ($this->state->getMode() === State::MODE_DEVELOPER) {
$this->logger->critical(
$this->logger->info(
"Broken reference: the '{$name}' element cannot be added as child to '{$parentName}', " .
'because the latter doesn\'t exist'
);
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/View/Test/Unit/Layout/Data/StructureTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function testReorderChildElementLog($loggerExpects, $stateMode)
->method('getMode')
->willReturn($stateMode);
$this->loggerMock->expects($loggerExpects)
->method('critical')
->method('info')
->with(
"Broken reference: the '{$childName}' tries to reorder itself towards '', but " .
"their parents are different: '{$parentName}' and '' respectively."
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/View/Test/Unit/Layout/ScheduledStructure/HelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function testScheduleElementLog($loggerExpects, $stateMode)
->method('getMode')
->willReturn($stateMode);
$this->loggerMock->expects($loggerExpects)
->method('critical')
->method('info')
->with(
"Broken reference: the '{$key}' element cannot be added as child to '{$parentName}', " .
'because the latter doesn\'t exist'
Expand Down