Skip to content

Added translation to label argument xml. #9095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<block class="Magento\Customer\Block\Account\SortLinkInterface" name="customer-account-navigation-downloadable-products-link">
<arguments>
<argument name="path" xsi:type="string">downloadable/customer/products</argument>
<argument name="label" xsi:type="string">My Downloadable Products</argument>
<argument name="label" xsi:type="string" translate="true">My Downloadable Products</argument>
<argument name="sortOrder" xsi:type="number">220</argument>
</arguments>
</block>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<block class="Magento\Customer\Block\Account\SortLinkInterface" name="customer-account-navigation-product-reviews-link">
<arguments>
<argument name="path" xsi:type="string">review/customer</argument>
<argument name="label" xsi:type="string">My Product Reviews</argument>
<argument name="label" xsi:type="string" translate="true">My Product Reviews</argument>
<argument name="sortOrder" xsi:type="number">50</argument>
</arguments>
</block>
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Rss/view/frontend/layout/default.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<referenceBlock name="footer_links">
<block class="Magento\Framework\View\Element\Html\Link\Current" name="rss-link" ifconfig="rss/config/active">
<arguments>
<argument name="label" xsi:type="string">RSS</argument>
<argument name="label" xsi:type="string" translate="true">RSS</argument>
<argument name="path" xsi:type="string">rss</argument>
</arguments>
</block>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Shipping/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -180,3 +180,4 @@ City,City
"Shipping Policy","Shipping Policy"
"Shipping Methods","Shipping Methods"
"Track your order","Track your order"
"Track All Shipments","Track All Shipments"
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<block class="Magento\Framework\View\Element\RendererList" name="sales.order.shipment.renderers" as="renderer.list"/>
<block class="Magento\Shipping\Block\Tracking\Link" name="track-all-link" template="tracking/link.phtml">
<arguments>
<argument name="label" xsi:type="string">Track All Shipments</argument>
<argument name="label" xsi:type="string" translate="true">Track All Shipments</argument>
</arguments>
</block>
<block class="Magento\Sales\Block\Order\Comments" name="shipment_comments" template="order/comments.phtml"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<block class="Magento\Framework\View\Element\RendererList" name="sales.order.shipment.renderers" as="renderer.list"/>
<block class="Magento\Shipping\Block\Tracking\Link" name="track-all-link" template="tracking/link.phtml">
<arguments>
<argument name="label" xsi:type="string">Track All Shipments</argument>
<argument name="label" xsi:type="string" translate="true">Track All Shipments</argument>
</arguments>
</block>
<block class="Magento\Sales\Block\Order\Comments" name="shipment_comments" template="order/comments.phtml"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<block class="Magento\Customer\Block\Account\SortLinkInterface" ifconfig="wishlist/general/active" name="customer-account-navigation-wish-list-link">
<arguments>
<argument name="path" xsi:type="string">wishlist</argument>
<argument name="label" xsi:type="string">My Wish List</argument>
<argument name="label" xsi:type="string" translate="true">My Wish List</argument>
<argument name="sortOrder" xsi:type="number">210</argument>
</arguments>
</block>
Expand Down