Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli info di #9103

Merged
merged 28 commits into from
Apr 13, 2017
Merged

Cli info di #9103

merged 28 commits into from
Apr 13, 2017

Conversation

springerin
Copy link

@springerin springerin commented Apr 2, 2017 •
edited by ishakhsuvarov
Loading

Added cli command to retrieve DI configured for the certain class or interface: which preference is defined, which virtual types exist, how parameters are configured, what plugins exist.

Description

Fixed Issues (if relevant)

1.magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dependency Injection Info for the Interfaces and Classes

Manual testing scenarios

  1. Run bin/magento dev:di:info "Magento\Catalog\Api\Data\ProductInterface"
  2. Expected Result:
DI configuration for the class Magento\Catalog\Api\Data\ProductInterface in the GLOBAL area

Preference: Magento\Catalog\Model\Product

Constructor Parameters:
+--------------------------------+--------------------------------------------------------------------------+------------------+
| Name                           | Requested Type                                                           | Configured Value |
+--------------------------------+--------------------------------------------------------------------------+------------------+
| context                        | Magento\Framework\Model\Context                                          |                  |
| registry                       | Magento\Framework\Registry                                               |                  |
| extensionFactory               | Magento\Framework\Api\ExtensionAttributesFactory                         |                  |
| customAttributeFactory         | Magento\Framework\Api\AttributeValueFactory                              |                  |
| storeManager                   | Magento\Store\Model\StoreManagerInterface                                |                  |
| metadataService                | Magento\Catalog\Api\ProductAttributeRepositoryInterface                  |                  |
| url                            | Magento\Catalog\Model\Product\Url                                        |                  |
| productLink                    | Magento\Catalog\Model\Product\Link                                       |                  |
| itemOptionFactory              | Magento\Catalog\Model\Product\Configuration\Item\OptionFactory           |                  |
| stockItemFactory               | Magento\CatalogInventory\Api\Data\StockItemInterfaceFactory              |                  |
| catalogProductOptionFactory    | Magento\Catalog\Model\Product\OptionFactory                              |                  |
| catalogProductVisibility       | Magento\Catalog\Model\Product\Visibility                                 |                  |
| catalogProductStatus           | Magento\Catalog\Model\Product\Attribute\Source\Status                    |                  |
| catalogProductMediaConfig      | Magento\Catalog\Model\Product\Media\Config                               |                  |
| catalogProductType             | Magento\Catalog\Model\Product\Type                                       |                  |
| moduleManager                  | Magento\Framework\Module\Manager                                         |                  |
| catalogProduct                 | Magento\Catalog\Helper\Product                                           |                  |
| resource                       | Magento\Catalog\Model\ResourceModel\Product                              |                  |
| resourceCollection             | Magento\Catalog\Model\ResourceModel\Product\Collection                   |                  |
| collectionFactory              | Magento\Framework\Data\CollectionFactory                                 |                  |
| filesystem                     | Magento\Framework\Filesystem                                             |                  |
| indexerRegistry                | Magento\Framework\Indexer\IndexerRegistry                                |                  |
| productFlatIndexerProcessor    | Magento\Catalog\Model\Indexer\Product\Flat\Processor                     |                  |
| productPriceIndexerProcessor   | Magento\Catalog\Model\Indexer\Product\Price\Processor                    |                  |
| productEavIndexerProcessor     | Magento\Catalog\Model\Indexer\Product\Eav\Processor                      |                  |
| categoryRepository             | Magento\Catalog\Api\CategoryRepositoryInterface                          |                  |
| imageCacheFactory              | Magento\Catalog\Model\Product\Image\CacheFactory                         |                  |
| entityCollectionProvider       | Magento\Catalog\Model\ProductLink\CollectionProvider                     |                  |
| linkTypeProvider               | Magento\Catalog\Model\Product\LinkTypeProvider                           |                  |
| productLinkFactory             | Magento\Catalog\Api\Data\ProductLinkInterfaceFactory                     |                  |
| productLinkExtensionFactory    | Magento\Catalog\Api\Data\ProductLinkExtensionFactory                     |                  |
| mediaGalleryEntryConverterPool | Magento\Catalog\Model\Product\Attribute\Backend\Media\EntryConverterPool |                  |
| dataObjectHelper               | Magento\Framework\Api\DataObjectHelper                                   |                  |
| joinProcessor                  | Magento\Framework\Api\ExtensionAttribute\JoinProcessorInterface          |                  |
| data                           |                                                                          | <empty array>    |
+--------------------------------+--------------------------------------------------------------------------+------------------+

Plugins:
+--------+--------+------+
| Plugin | Method | Type |
+--------+--------+------+

Plugins for the Preference:
+--------------------------------------------------------+--------------------+-------+
| Plugin                                                 | Method             | Type  |
+--------------------------------------------------------+--------------------+-------+
| Magento\Swatches\Model\Plugin\Product                  | getMediaAttributes | after |
| Magento\CatalogInventory\Model\Plugin\AfterProductLoad | load               | after |
| Magento\Bundle\Model\Plugin\Product                    | getIdentities      | after |
+--------------------------------------------------------+--------------------+-------+

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

vrann and others added 23 commits April 1, 2017 14:04
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
a7934d2 
…endency Injection Info for the Interfaces and Classes

- Create class to collect DI configuration information
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
7e6d451 
…endency Injection Info for the Interfaces and Classes

- Create method to retrieve constructor parameters info
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
368b26e 
…endency Injection Info for the Interfaces and Classes

- Create Class for Di info command
Merge remote-tracking branch 'origin/cli-info-di' into cli-info-di
e69a307
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
4dc7a92 
…endency Injection Info for the Interfaces and Classes

- Create method to retrieve virtual types of the class and its preference
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
fe068fb 
…into cli-info-di
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
2574765 
…endency Injection Info for the Interfaces and Classes

- added in di.xml the dev_di_info command
Merge remote-tracking branch 'origin/cli-info-di' into cli-info-di
db61414
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
551dd4e 
…endency Injection Info for the Interfaces and Classes

- added the execute method
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
2ebd560 
…endency Injection Info for the Interfaces and Classes

- format the output of the command
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
789cb19 
…endency Injection Info for the Interfaces and Classes

- added pluginlist model to recover the information about the plugin for the specified class
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
32479cd 
…into cli-info-di

# Conflicts:
#	app/code/Magento/Developer/Model/Di/Information.php
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
2608b1d 
…into cli-info-di

# Conflicts:
#	app/code/Magento/Developer/Model/Di/Information.php
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
f580225 
…endency Injection Info for the Interfaces and Classes

- added type name to plugin method instead of id
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
e9c71c0 
…into cli-info-di
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
2cb46ff 
…into cli-info-di

# Conflicts:
#	app/code/Magento/Developer/Console/Command/DiInfoCommand.php
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
2da051d 
…endency Injection Info for the Interfaces and Classes

- added check existence of className in the inherited array
Merge remote-tracking branch 'origin/cli-info-di' into cli-info-di
2ac9182
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
b853969 
…endency Injection Info for the Interfaces and Classes

- added plugins info about preference
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
7cef537 
…into cli-info-di

- Added support for the virtual types
@vrann
Merge branch 'cli-info-di' of https://github.com/springerin/magento2 …
1077a97 
…into cli-info-di

# Conflicts:
#	app/code/Magento/Developer/Console/Command/DiInfoCommand.php
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
3d1ffab 
…endency Injection Info for the Interfaces and Classes

- added support for array type parameters
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
63b14ad 
…endency Injection Info for the Interfaces and Classes

- added support for array type parameters
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 2, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
22120a2 
…endency Injection Info for the Interfaces and Classes

- added unit test for Information class
@ishakhsuvarov
Copy link
Contributor

Hi @springerin

  • Please sign the CLA before we can proceed with the processing of this PR. (Make sure, that the email address you have used in the commit is present in your GitHub profile).
  • Please look into the test fails on Travis CI.

Thanks!

@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 10, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Apr 10, 2017
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
2d03656 
…endency Injection Info for the Interfaces and Classes

- fixed the virtual types message
- added information about the area
@vrann vrann self-assigned this Apr 12, 2017
@vrann
magento-hackathon/Imagine2017#11: Create new CLI command: Collect Dep…
fd9321c 
…endency Injection Info for the Interfaces and Classes

- fixed issue with the empty constructor parameters list
- fixed static test
@vrann
Copy link
Contributor

vrann commented Apr 12, 2017 •
edited
Loading

@ishakhsuvarov fixed tests, please pay attention to acceptance test
CLA was signed, @springerin is trying to re-sign it again

@vrann
Copy link
Contributor

vrann commented Apr 12, 2017 •
edited
Loading

@springerin CLA was signed but the system cannot record it due to error. We can assume that it is signed.

@magento-team magento-team merged commit fd9321c into magento:develop Apr 13, 2017
magento-team pushed a commit that referenced this pull request Apr 13, 2017
MAGETWO-67410: Cli info di #9103
270a456
@magento-team
Copy link
Contributor

@springerin thank you for your contribution to Magento 2 project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrann vrann

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@springerin @magento-cicd2 @ishakhsuvarov @vrann @magento-team