Skip to content

Redundant expression */1 in crontab.xml #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2017
Merged

Redundant expression */1 in crontab.xml #9108

merged 2 commits into from
Apr 11, 2017

Conversation

giacmir
Copy link
Member

@giacmir giacmir commented Apr 3, 2017 •
edited by ishakhsuvarov
Loading

In Magento_Sales crontab.xml there are several cron expressions like this *\1 that is redundant since * already means "every time unit". I changed them to a regular * in order to:

  • Have an uniform style with the other crontab.xml files
  • Remove the "wtf effect" when one sees that strange thing.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

pocallaghan
pocallaghan reviewed Apr 6, 2017
View reviewed changes
app/code/Magento/Sales/etc/crontab.xml Outdated
@@ -28,28 +28,28 @@
<schedule>0 0 * * *</schedule>
</job>
<job name="sales_grid_order_async_insert" instance="SalesOrderIndexGridAsyncInsertCron" method="execute">
<schedule>*/1 * * * *</schedule>
<schedule>* * * * *</schedule>
</job>
<job name="sales_grid_order_invoice_async_insert" instance="SalesInvoiceIndexGridAsyncInsertCron" method="execute">
<schedule>*/1 * * * *</schedule>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this one wasn't updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I overlooked it.

@ishakhsuvarov ishakhsuvarov self-assigned this Apr 10, 2017
@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 10, 2017
@magento-team magento-team merged commit 28bfada into magento:develop Apr 11, 2017
magento-team pushed a commit that referenced this pull request Apr 11, 2017
MAGETWO-67286: Redundant expression */1 in crontab.xml #9108
70659f9
@okorshenko
Copy link
Contributor

@giacmir thank you for Pull Request. Greate to see your contributions again!

@giacmir giacmir deleted the cron-expressions branch December 4, 2017 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocallaghan pocallaghan pocallaghan left review comments

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@giacmir @okorshenko @pocallaghan @magento-team @ishakhsuvarov