Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issues with API #9124

Merged
merged 7 commits into from
Apr 19, 2017
Merged

Solve issues with API #9124

merged 7 commits into from
Apr 19, 2017

Conversation

paales
Copy link
Contributor

@paales paales commented Apr 4, 2017

Description

Our team is working on a new API service layer (GraphQL) that intensively uses the API retrospection classes and noticed that there are some inconsistencies in the API

  • Some comment sort orders aren't correct, fixed for ProductAttributeMediaGalleryEntryInterface, ConfigurableProductManagementInterface.
  • Replaced di injections and argument types of SearchCriteria with SearchCriteriaInterface

generated/.htaccess Outdated Show resolved Hide resolved
…earchCriteria instead of SearchCriteriaInterface
@ishakhsuvarov
Copy link
Contributor

@paales Did you use Replace in Path or created some automated tool to achieve the purpose?

@paales
Copy link
Contributor Author

paales commented Apr 12, 2017

Hi @ishakhsuvarov

I did a find and replace at some point. The functionality was validated as it generates a complete schema of all the complete service layer in GraphQL and the endpoints now work as expected :)

@ishakhsuvarov
Copy link
Contributor

Hi @paales
We are still in the process of review, as potentially this PR may cause backwards compatibility issue for some of the 3rd party extensions. We will keep you updated.
Thanks.

@paales
Copy link
Contributor Author

paales commented Apr 13, 2017

Understandable :)

@vrann
Copy link
Contributor

vrann commented Apr 15, 2017

@paales I've been researching GraphQL for Magento myself and found it very promising for the next generation of the APIs. Would be curious to see your perspective on this subject! If there is anything you want to share, we can connect via slack.

@okorshenko okorshenko self-assigned this Apr 18, 2017
@paales
Copy link
Contributor Author

paales commented Apr 18, 2017

Hi @vrann, sure! I've send you a message on Slack (on the super secret Magento chat)

@magento-team magento-team merged commit bbd7b88 into magento:develop Apr 19, 2017
magento-team pushed a commit that referenced this pull request Apr 19, 2017
@magento-team
Copy link
Contributor

@paales thank you for your contribution

@paales paales deleted the api-fixes branch April 19, 2017 11:29
magento-team pushed a commit that referenced this pull request Oct 5, 2017
 - Updated getList method signatures to be compatible with SearchCriteriaInterface instead of SearchCriteria
@paales paales added the Partner: Reach Digital Pull Request is created by partner Reach Digital label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants