-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issues with API #9124
Solve issues with API #9124
Conversation
…earchCriteria instead of SearchCriteriaInterface
@paales Did you use |
I did a find and replace at some point. The functionality was validated as it generates a complete schema of all the complete service layer in GraphQL and the endpoints now work as expected :) |
Hi @paales |
Understandable :) |
@paales I've been researching GraphQL for Magento myself and found it very promising for the next generation of the APIs. Would be curious to see your perspective on this subject! If there is anything you want to share, we can connect via slack. |
Hi @vrann, sure! I've send you a message on Slack (on the super secret Magento chat) |
@paales thank you for your contribution |
- Updated getList method signatures to be compatible with SearchCriteriaInterface instead of SearchCriteria
Description
Our team is working on a new API service layer (GraphQL) that intensively uses the API retrospection classes and noticed that there are some inconsistencies in the API
ProductAttributeMediaGalleryEntryInterface
,ConfigurableProductManagementInterface
.SearchCriteria
withSearchCriteriaInterface