Product Wizard: Use result type Layout instead of page layout #9129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f default layout handle and to fit type hint
|
|
magento-team
pushed a commit
that referenced
this pull request
Apr 22, 2017
… layout #9129 - Unit test added
magento-team
pushed a commit
that referenced
this pull request
Apr 22, 2017
|
@klein0r thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary removal of default layout handle and to fit type hint
Description
It doesn't make sense at all to use a page layout and remove the default handle. You can get the same result by using the Layout type directly.