Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and invalid method #9215

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

adragus-inviqa
Copy link
Contributor

@adragus-inviqa adragus-inviqa commented Apr 12, 2017

a) there is no $this->_getDomConfigModel() method
b) method is unused

a) there is no `$this->_getDomConfigModel()` method
b) method is unused
@sivajik34
Copy link
Contributor

@adragus-inviqa may be we can add deprecated, without deleting the method.

@adragus-inviqa
Copy link
Contributor Author

Yeah, I suppose we could, but I looked for its usage, and couldn't find one. If you deprecate it, it's still callable. But calling it would give you a fatal error, as there's no $this->_getDomConfigModel() method.

I'd rather we get rid of it.

@vrann
Copy link
Contributor

vrann commented Apr 12, 2017

@adragus-inviqa per our backward compatibility policy method should deprecate method first and then it will be removed in the next release. Please deprecate it.

@adragus-inviqa
Copy link
Contributor Author

adragus-inviqa commented Apr 12, 2017

Ok, I will. But what about the fact that people can still call it, and trigger a fatal error? Shouldn't I remove the method body at least?

PS: Do you actually remove deprecated stuff in the subsequent release? 🤔

@vrann
Copy link
Contributor

vrann commented Apr 12, 2017

@adragus-inviqa ah, good point. If there is fatal exception from using it, then better to remove.

@vrann vrann self-assigned this Apr 12, 2017
@vrann vrann added this to the April 2017 milestone Apr 12, 2017
@magento-team magento-team merged commit 3ecf591 into magento:develop Apr 13, 2017
@magento-team
Copy link
Contributor

@adragus-inviqa thank you for your contribution. Your Pull Request has been successfully merged

@adragus-inviqa adragus-inviqa deleted the patch-5 branch April 13, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants