-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Zend_Log with Psr\Log\LoggerInterface #9285
Replace Zend_Log with Psr\Log\LoggerInterface #9285
Conversation
Hi @tdgroot Please, look at this file: https://github.com/magento/magento2/blob/develop/dev/tests/api-functional/framework/bootstrap.php#L28 |
Hey @okorshenko The fatal error happenened in the bootstrap of the integration test as well. |
@tdgroot Thank you for the contribution |
Replace
Zend_Log
withPsr\Log\LoggerInterface
to prepare for upgrade to higher ZF versions.Description
I replaced
Zend_Log
withPsr\Log\LoggerInterface
in Magento Framework.To simplify the conversion I changed method call
$logger->log($message, \Zend_Log::INFO)
into
$logger->info($message)
.Obviously, I had to change the ShellTest a bit to make it compatible with the
Psr\Log\LoggerInterface
.Fixed Issues
Testing scenarios
Run the unit test
\Magento\Framework\Test\Unit\ShellTest
.Contribution checklist