-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Varnish Vcl generator command #9286
[WIP] Varnish Vcl generator command #9286
Conversation
self::BACKEND_PORT_OPTION, | ||
null, | ||
InputOption::VALUE_REQUIRED, | ||
'Backend post for configuration', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: port
, not post
. Also, I had a bit of problem understanding the phrase Backend port for configuration
. Can we be more explicit? I know what it does, but I just think some people will need more info about it. Don't be terse on documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment. Do you have suggestions how to better call it?
- fixed static and integration tests - moved interfaces to proper namespace
- fixed static and integration tests - moved interfaces to proper namespace
- fixed static and integration tests
- fixed static and integration tests
- fixed static and integration tests
@piotrkwiecinski thank you for your contribution |
@piotrkwiecinski I just saw this and I wanted to understand the code better. I couldn't find a switch for the admin value in the code and I wanted to know if this is not necessary or it is just not taken into account in this PR. Thanks! |
@magento-team I see this PR isn't in 2.2 as of 2.2.7. Is there a backport or is this a 2.3 fix only? |
Add new CLI command to allow generation of Varnish VCL configuration
Description
In addition to new CLI to generate VCL file same generator is now used in admin UI.
Fixed Issues (if relevant)
Manual testing scenarios
Automated tests will be added tomorrow
Contribution checklist