Improved check for attribute codes in "additional_attributes" field #9299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccasciotti thank you for your contribution. Your Pull Request has been successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to handle uppercased attribute codes in "additional_attributes" field.
Assume that you have this content in additional_attributes field:
attributecode1=value1,ATTRIBUTECODE2=value2
and in your database both attributes have code in lowercase.
With current behavior the second attribute is skipped, with this PR the system also handles the second attribute without skipping it.
I've added also two new test cases to test both methods
parseAttributesWithoutWrappedValuesandparseAttributesWithWrappedValues