Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standard violations in the Framework\Config namespace #9328

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Fixed coding standard violations in the Framework\Config namespace #9328

merged 2 commits into from
Apr 21, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 20, 2017

Fixed coding standard violations in the Framework\Config namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed @codingStandardsIgnoreFile at the head of the files
  • Fixed indentation
  • Changed is_null call to the === null compare

…o that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

- Removed @codingStandardsIgnoreFile at the head of the files
- Fixed indentation
- Changed is_null call to the === null compare
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 20, 2017

CLA assistant check
All committers have signed the CLA.

- Fixed wrong identation
@okorshenko okorshenko self-assigned this Apr 20, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 20, 2017
@magento-team magento-team merged commit 776efe6 into magento:develop Apr 21, 2017
magento-team pushed a commit that referenced this pull request Apr 21, 2017
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution to Magento 2 project

@dverkade dverkade deleted the Fix_coding_standard_in_Framework-Config branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants